Skip to content

Conversation

@neznaika0
Copy link
Contributor

Description
is_file($target) not needed, as it will be overwritten anyway.
Question: Is it worth checking copy() and throwing an exception?

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0 neznaika0 changed the title refactor: Fix phpstan always true refactor: Fix phpstan booleanAnd.rightAlwaysTrue Jan 3, 2025
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 4, 2025
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale Pull requests with conflicts label Jan 6, 2025
@neznaika0 neznaika0 force-pushed the refactor/phpstan-right-true branch from fae590b to 9fcaa61 Compare January 7, 2025 18:35
@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Jan 7, 2025
@paulbalandan paulbalandan requested review from kenjis and removed request for kenjis January 8, 2025 00:55
@paulbalandan paulbalandan merged commit 708fb6d into codeigniter4:develop Jan 10, 2025
41 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-right-true branch January 10, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants